Use localized date and time formats in interpolate_hash
#674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davidgumberg Would you mind adding a test for this please? |
Originally disabled in 518c053 (remove timezone sensible test because it breaks on windows, 2008-06-24) Test now works in Windows 10, Ruby 3.2.2 (via 'RubyInstaller')
davidgumberg
force-pushed
the
datetime_interpolation
branch
from
cb79900 to
a9724a9
Compare
Interpolated strings containing Times or Dates should respect `:default` formatting options of locale.
davidgumberg
force-pushed
the
datetime_interpolation
branch
from
a9724a9 to
ffb18e9
Compare
|
@radar Thanks for the review, I've added some tests. Is this behavior desired? test "interpolation: given a Date with no default format set it raises I18n::MissingTranslationData" do
assert_raises(I18n::MissingTranslationData) do
date = Date.new(2008, 3, 1)
interpolate(:default => '%{date}', :date => date)
end
endI am not really sure how much code there is in the wild that passes Date's and Time's to The gentler alternative would be to default to If you have a chance, let me know what you think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interpolated
Time's andDate's should respect default formatting options and locale.Rails, for example, passes
DateandTimeActiveRecord attributes toI18n::t.(This may also avoid triggering some deprecation warnings in Rails eg: rails/rails#48960)